openpilot

Thanks for the reference! That certainly does look much nicer. That being said, I do still see some "magical" looking constants and dictionary keys here[1], as well as lots of small numbers later in the file. I think it would be confidence-inspiring to have those better documented as well. Edit: I found some more magic-looking bytestrings in the Volkswagen support here[2]. [1]: https://github.com/commaai/openpilot/blob/de0ce142ae51cf9c85... [2]: https://github.com/commaai/openpilot/blob/de0ce142ae51cf9c85...

See my other comment about Ford code being reference only. Supported cars have most signals defined in a dbc file, the mapping from name to id and bytes. See https://github.com/commaai/opendbc This results in much cleaner car abstraction layers: https://github.com/commaai/openpilot/blob/de0ce142ae51cf9c85...

I'm not anywhere near a specialist when it comes to car software, CAN, or self-driving, but I'm concerned by some of the code that (appears to) control some of the supported cars: I pulled up a random file[1], and it's littered with undocumented bytestrings that are apparently sent over the CAN bus, as magic constants (with accompanying comments that mention "aggressive" and "laggy" behavior). I have no insight into any of the proprietary work in this space, so I have no idea whether this is unique or commonplace. But it certainly isn't confidence inspiring, particularly as a cyclist. [1]: https://github.com/commaai/openpilot/blob/de0ce142ae51cf9c85...

This is great for projects where management or tracking of some sort is done from a public Google spreadsheet. Here's some examples where I've put it to use. Here's a project where I sent in a PR that was merged to display annotation progress and put a badge atop a README, traditional: https://github.com/commaai/comma10k/pull/2767 Here's a wiki entry using it to display the current number of bounty contributors and bounty amount ($8K+!): https://github.com/commaai/openpilot/wiki/Toyota-Lexus#2021-... If you're organizing something for your community using a spreadsheet, maybe consider using Cell Shield to put a little badge backed from a cell in that spreadsheet somewhere visible.

comma.ai | Software Engineers + Infrastructure Engineer | ALL FULL-TIME | ONSITE ONLY Comma is a profitable company solving self driving cars while delivering shippable intermediaries. Tesla Autopilot like functionality for your Toyota, Honda, and more. See our open source driving agent on GitHub: https://github.com/commaai/openpilot Watch it here on YouTube: https://www.youtube.com/watch?v=mgAbfr42oI8 We’re hiring: Software engineers to develop openpilot through new features, simulation, and testing infrastructure. Infrastructure engineer to work on our tooling, regression tests, and simulator. Our stack is largely Python, with some C/C++ and JS(React) Interview Process (roughly) = Coding challenge + 2 phone screens + paid micro-internship on site Visit https://comma.ai/jobs for more detailed job descriptions *Reach out with a GitHub/L

comma.ai | Software Engineers + Infrastructure Engineer | ALL FULL-TIME | ONSITE ONLY Comma is a profitable company solving self driving cars while delivering shippable intermediaries. Tesla Autopilot like functionality for your Toyota, Honda, and more. See our open source driving agent on GitHub: https://github.com/commaai/openpilot Watch it here on YouTube: https://www.youtube.com/watch?v=mgAbfr42oI8 We’re hiring: Software engineers to develop openpilot through new features, simulation, and testing infrastructure. Infrastructure engineer to work on our tooling, regression tests, and simulator. Our stack is largely Python, with some C/C++ and JS(React) Interview Process (roughly) = Coding challenge + 2 phone screens + paid micro-internship on site Visit https://comma.ai/jobs for more detailed job descriptions *Reach out with a GitHub/L

It's a monorepo. The "should work" commit you are referring to is about the formatting of the SSIDs in the WiFi network selection menu. https://github.com/commaai/openpilot/commit/34ff2951d4172710...

> Automakers and Comma are operating at completely different scales. Orders of magnitude apart. Super Cruise has 7 million miles driven [0]. Comma has 35 million miles driven [1] > Comma also incentivizes customers to keep quiet if the autopilot fails How do you figure? The amount of weird hatred people have towards comma is much more than Cadillac. You can find literally hours of real life video of comma driving in cars. Professional reviewers like Consumer Reports don't have a pro comma bias. Comma doesn't have a PR guy or teams of lawyers. They're not a hundred billion dollar company. They're a dozen or so engineers. They have no influence over trade publications or blogs. I think people and reviewers would judge comma much more harshly than they would big auto. > At minimum, automakers are working with safety regulators > openpilot is

This just isn't true as far as I am aware. The vehicle interfaces[0] and control loop are all in Python. It doesn't help if other components are in C if your commands to the vehicle are interrupted by GC pauses. Even if it was true, and it was all in C, it is only better because there is no GC -- there are still a myriad of potential issues that the auto industry routinely addresses in both software and hardware that Comma either cannot or does not. Not to say they are perfect, but Comma is well below any sort of bar. [0] https://github.com/commaai/openpilot/tree/master/selfdrive/c...