progressbar

https://github.com/doches/progressbar/blob/master/lib/progre... The correct solution would be a) check the length of format, and if it less than or equal to 4 but greater than 0, then copy the bytes, else, don't... I guess? Why is 4 such an arbitrary chosen number? // new->format is allocated to 4 bytes size_t len = strlen(format); if(len > 0 && len <= 4) { memcpy(new->format, format, len); //i to < 4 new->format[3] = '\0'; } Or it just be better to allocate the new->length to the return value of strlen(format) + 1.

Consider checking the return value of malloc (e.g: https://github.com/doches/progressbar/blob/master/lib/progre...) You're setting users/yourself up for a disaster if you're assuming it will never fail. The standard [0] states that the size of `char` will be 1 byte. So there is no point in doing the sizeof operator on char. (e.g: https://github.com/doches/progressbar/blob/master/lib/progre...) 6.5.3.4 - Paragraph 3 > The sizeof operator... (page 80) [0] http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1124.pdf