enzyme

ljharb is an extremely interesting person. There’s no doubting the positive impact he’s had on the OSS community and the work he’s done. However, there are some things he does that are incomprehensible. For example, Enzyme. Over three years ago this issue was opened for Enzyme on React 17: https://github.com/enzymejs/enzyme/issues/2429 Nothing moved for a while, and I think he said something along the lines of “if you want React 17 support, stop complaining and help”. So the community got involved. There are multiple PRs adding React 17 support. Many unofficial React 17 adapters. A lot of people have put a lot of work into this, ensuring compatibility, coverage etc. Yet to this day, none of them have been merged. Eg https://github.com/enzymejs/enzyme/pull/2564 Given the amount of time that has passed, and the work the community has put in

Enzyme still needs to support it. https://github.com/airbnb/enzyme/issues/1553

The adapter system is super interesting: https://github.com/airbnb/enzyme/blob/master/docs/guides/mig... This might be the way to go for complex dependencies like React where APIs move in and out of the main package, or could be implemented by third parties (like how Preact can supply render and createElement in a mostly-compatible way). It also makes clear that semver dependencies in package.json are insufficient to describe the library combinations that work in the main package.

On the flipside of alexdrans, I suggest looking into using Airbnb's Enzyme[0] for React and Facebook's Jest[1] for testing React components. [0]: https://github.com/airbnb/enzyme [1]: https://github.com/facebook/jest

I looked through the patterns and I wonder what makes them 'idiomatic'? I've found it useful to use wrapper libraries like Enzyme [0] and Teaspoon [1] when testing React components and interactions. [0] https://github.com/airbnb/enzyme [1] https://github.com/jquense/teaspoon

I'm a fan of HOCs as well. My only problem with them is that I'm also a fan of shallow testing, and HOCs don't play nicely with shallow testing. I'm waiting on something like this (https://github.com/airbnb/enzyme/issues/250) to get implemented

See also Enzyme, a testing library specifically for React, that allows you to easy assert on both deep and shallow renders of the React DOM. https://github.com/airbnb/enzyme#basic-usage

I first encountered LGTM on some of Airbnb's open source repos, here's an example of it at work on a closed [1] and open [2] Enzyme PR: 1: https://github.com/airbnb/enzyme/pull/449 2: https://github.com/airbnb/enzyme/pull/459 I love that this enforces a social practice a lot of teams use already, and I'm pushing to add it to my own team's workflow (both internal and for open source contributions). Edit: another tool in the same vein people might be interested in is Facebook's mention-bot [3], which analyzes PR diffs and @-mentions people it thinks would be good reviewers based on git blame of lines touched. 3: https://github.com/facebook/mention-bot

For those who don't have the time to watch all the videos, here's are the github links to the most interesting projects from Day 2: NavigationExperimental: new multi-tab-aware navigation component https://github.com/facebook/react-native/tree/master/Librari... cf. previous work on in-app "paths"by TaskRabbit http://tech.taskrabbit.com/blog/2015/09/21/react-native-exam... Nuclide is an IDE for building react-native apps http://nuclide.io/docs/quick-start/getting-started/ source https://github.com/facebook/nuclide Realm is a mobile database: an alternative to SQLite & key-value stores. Previously iOS and Java, now works with react native too https://github.com/realm/realm-js Exponent lets you write apps in js w/o need for iOS/Android toolchain https://exponentjs.com/ Static site generator using React.js https://github.com/gatsbyjs/gatsby Re

For this very reason they've opened an issue to rename the project: https://github.com/airbnb/reagent/issues/46