UNunbeli·Mar 7, 2017
I think that won't even compile due to an accidentally pasted URL here:
https://github.com/zcoinofficial/zcoin/commit/0359bcb2ead7fe...
In Zcoin implementation bug enabled attacker to create over 500K Zcoinsfiroorg
firo
C++2017–2017
firoorg / firo
firo
The privacy-focused cryptocurrency
9Distinct people
10Mentions
0Explicit recommenders
807GitHub stars
What to know before exploring
What it is
The privacy-focused cryptocurrency
GitHub
Where it is used
No documented product use has been verified yet.
What people are saying
No recommendation phrase was found in the indexed comments.
No classified warning is attached to this page. Read the discussions before treating silence as approval.
Also in these discussions
No other repository is repeatedly linked in the same discussions.
This week on Hacker News
Nov 8–Nov 15 UTC · Direct repository links and separately labeled related project stories. Indexed through 11/15/2026, 5:03:38 AM UTC.
No direct repository links were found in the indexed HN discussions over the past seven days. Older discussions are available below.
Mentions over time
HN mentions by day10 dated mentions
Observed mentions: 2017-02-17 22:48:14 UTC to 2017-03-07 09:42:18 UTC.
Counts come from the repository’s dated source evidence. Index cutoff: 2026-11-02 08:16:59 UTC.
View mention counts and date ranges
| Period | Start (UTC) | End (exclusive, UTC) | Mentions | Submissions | Comments |
|---|---|---|---|---|---|
| Feb 17 | 2017-02-17 00:00:00 UTC | 2017-02-18 00:00:00 UTC | 2 | 0 | 2 |
| Feb 18 | 2017-02-18 00:00:00 UTC | 2017-02-19 00:00:00 UTC | 5 | 0 | 5 |
| Feb 19 | 2017-02-19 00:00:00 UTC | 2017-02-20 00:00:00 UTC | 0 | 0 | 0 |
| Feb 20 | 2017-02-20 00:00:00 UTC | 2017-02-21 00:00:00 UTC | 0 | 0 | 0 |
| Feb 21 | 2017-02-21 00:00:00 UTC | 2017-02-22 00:00:00 UTC | 0 | 0 | 0 |
| Feb 22 | 2017-02-22 00:00:00 UTC | 2017-02-23 00:00:00 UTC | 0 | 0 | 0 |
| Feb 23 | 2017-02-23 00:00:00 UTC | 2017-02-24 00:00:00 UTC | 0 | 0 | 0 |
| Feb 24 | 2017-02-24 00:00:00 UTC | 2017-02-25 00:00:00 UTC | 0 | 0 | 0 |
| Feb 25 | 2017-02-25 00:00:00 UTC | 2017-02-26 00:00:00 UTC | 0 | 0 | 0 |
| Feb 26 | 2017-02-26 00:00:00 UTC | 2017-02-27 00:00:00 UTC | 0 | 0 | 0 |
| Feb 27 | 2017-02-27 00:00:00 UTC | 2017-02-28 00:00:00 UTC | 0 | 0 | 0 |
| Feb 28 | 2017-02-28 00:00:00 UTC | 2017-03-01 00:00:00 UTC | 0 | 0 | 0 |
| Mar 1 | 2017-03-01 00:00:00 UTC | 2017-03-02 00:00:00 UTC | 0 | 0 | 0 |
| Mar 2 | 2017-03-02 00:00:00 UTC | 2017-03-03 00:00:00 UTC | 0 | 0 | 0 |
| Mar 3 | 2017-03-03 00:00:00 UTC | 2017-03-04 00:00:00 UTC | 0 | 0 | 0 |
| Mar 4 | 2017-03-04 00:00:00 UTC | 2017-03-05 00:00:00 UTC | 0 | 0 | 0 |
| Mar 5 | 2017-03-05 00:00:00 UTC | 2017-03-06 00:00:00 UTC | 0 | 0 | 0 |
| Mar 6 | 2017-03-06 00:00:00 UTC | 2017-03-07 00:00:00 UTC | 0 | 0 | 0 |
| Mar 7 | 2017-03-07 00:00:00 UTC | 2017-03-08 00:00:00 UTC | 3 | 0 | 3 |
What Hacker News says
3 sourcesThe commit that fixes it does not change any tests:
https://github.com/zcoinofficial/zcoin/commit/0359bcb2ead7fe...
This indicates that the code in question is not covered by tests. I work on a database, for which correctness is paramount, so it's unnerving to see any code fixes not associated with test additions or changes. I would have thought that cryptocurrency had similar standards.
In Zcoin implementation bug enabled attacker to create over 500K ZcoinsThe error is here:
https://github.com/zcoinofficial/zcoin/blob/81a667867b5d8489...
and the line of code:
zccoinSpend.denomination == libzerocoin::ZQ_LOVELACE;
In other words, a statement with no effect. In D, such a line gives an error, not a warning:
Error: == has no effect in expression
You can force the statement to be accepted by casting it to void.
It's really past time for languages to not accept such code any more. Legacy code needs to get fixed.
In Zcoin implementation bug enabled attacker to create over 500K Zcoins