adblocker

Do you have to use Curl? It wouldn't render a lot of sites correctly anyway (anything that uses JS for rendering). Can you run a puppeteer/playwright instance (which control real browsers) and add an ad blocker to that? e.g. https://github.com/ghostery/adblocker or https://github.com/microsoft/playwright-python/issues/782

No well-known content blocker "process about 90,000 regexps" to find out whether a resource needs to be blocked or not, that's just not how it works internally. Last time I ran benchmarks of all well-known content blockers using Ghostery's benchmark tool[1], all of them could process a network request under 20µs on average. Some do have performance concerns, but it has nothing to do with network filtering, it has to do with other stuff they do beyond network filtering (for example see [2]) and declarativeNetRequest does not help there, so they will still suffer these performance issues under MV3. --- [1] https://github.com/ghostery/adblocker/tree/master/packages/a... [2] https://www.extremetech.com/computing/182428-ironic-iframes-...

Very cool implementation. I am wondering have you considered using something like https://github.com/cliqz-oss/adblocker which can sit on top of headless browser and do not require bridging to an extension.

> Does the Cliqz browser still disallow plugins, such as ad blockers? Hey, I work on Cliqz' adblocker (open-source here: https://github.com/cliqz-oss/adblocker). Cliqz browser comes built-in with adblocking, anti-tracking, anti-phishing and private search built-in so that users are protected by default. You can also install another one if you prefer since all Firefox extension are also available from Cliqz! But the one built-in is pretty good already[^1] and we're happy to get more feedback about how we can improve it! Finally, Cliqz search is also available standalone now so feel free to give it a try! https://beta.cliqz.com/ [^1]: https://whotracks.me/blog/adblockers_performance_study.html

Maybe you already do it, but I think integrating adblocker functionality when loading JS sites would be desirable to reduce load time. And if ads are what the API user is interested in, perhaps add a flag for whether or not one wants ads to load. Recommendation: https://github.com/cliqz-oss/adblocker Should be the fastest adblocker library (used by Ghostery, Cliqz and Brave)

It’s actually a Rust implementation of https://github.com/cliqz-oss/adblocker. So you can interpret the difference in the chart between Ghostery and Brave as being how much Rust improved performance over Node.js

Thanks a lot for your comment. The project is open source and everything needed to run the study comparisons is available as well there: https://github.com/cliqz-oss/adblocker/tree/master/bench/com... We would be really happy to see people running the same benchmarks and try to reproduce the results!