eslint-plugin-react

> [1] https://github.com/jsx-eslint/eslint-plugin-react/blob/maste... From what I remember, being able to pass children as a prop is considered a side-effect of an implementation detail, that breaks the expected abstraction. There really isn't any reason to use it, and I think there's a chance it may even limit what the virtual dom diffing can manage? Also this would prevent you from accidentally doing both at once: <MyComponent children={<div>Is it me?</div>}> <div>Or is it me?</div> </MyComponent> (I don't remember what React does in this situation)

This is pretty compelling. Why isn't it in the "recommended" preset of lints? In general, I find it frustrating that the eslint recommended presets don't document why they are recommended. I disable several of the rules in all my projects because they seem to be arbitrary stylistic choices (e.g. [0], [1], [2]). [0] https://typescript-eslint.io/rules/no-empty-function/ [1] https://github.com/jsx-eslint/eslint-plugin-react/blob/maste... [2] Specifically checkLoops of https://eslint.org/docs/latest/rules/no-constant-condition [edit] In looking up no-empty-function, I saw a stack overflow post that provides a compelling alternative of using `() => undefined` instead of `() => {}`, which suppresses the error. That should be shown as an example on the eslint page!

I try to focus on the issues rather than individuals, but the root of the problems in the listed eslint plugin libraries points to ljharb. If you do some simple digging into these libraries, you will find that these types of commits are quite common within them. https://github.com/jsx-eslint/eslint-plugin-react/commit/e1d... https://github.com/jsx-eslint/jsx-ast-utils/commit/bad51d062... https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/commit/... He would rather see the download count of these polyfill libraries https://github.com/ljharb/ljharb#projects-i-maintain increase, compared to assessing the health of the JavaScript ecosystem.

For what it's worth; `eslint-plugin-react` has been around for a long time and seems to support running in very old versions of Node.JS (back to v4[1] apparently! tho I can't find anything documenting that for sure.) I was surprised to learn that Object.values is only supported in Node >v7, Object.fronEntries was added in v12, etc. So for this project maybe the polyfills are needed. [1] https://github.com/jsx-eslint/eslint-plugin-react/pull/1038