compress

I'm in agreement he should use more test cases, but it looks like he used the same as Golang's compression tests [1]. Note he has other test cases in the subdirectories (also the same as Go) [2]. However I believe even better testing would be to fuzz it for a few hours [3]. [1] http://golang.org/src/compress/testdata/ [2] https://github.com/klauspost/compress/tree/master/zip/testda... [3] https://github.com/dvyukov/go-fuzz

I'm not criticizing the programmer's effort but whenever I see a new project as a "drop in replacement" and/or "50% to 3x faster", the first thing I always look for is the test data to verify that new bugs weren't introduced. I went to the test subfolder: https://github.com/klauspost/compress/tree/master/testdata I saw 3 files. The kind of test data I'd like to see for something like a compression library would be: 0 byte files 1 byte files 2,147,483,647 byte file 2,147,483,648 byte file 2,147,483,649 byte file (to check for bugs around signed 32-bit integers) 4,294,967,295 byte file 4,294,967,296 ... 4,294,967,297 ... (to check for bugs around unsigned 32-bit integers and see if 64bit was used when necessary for correctness) Also add files of sizes that straddle the boundary of algorithm's internal block buffers (e.g. 64kb or whatever).