geopattern

Another minor nitpick, here [1] you are using reflection. You can pretty easily convert it to a type switch [2], which is more idiomatic. [1] https://github.com/pravj/geo_pattern/blob/master/svg/svg.go#... [2] https://golang.org/doc/effective_go.html#type_switch

Hi @ImJasonH, I Developed this, let me answer you points :) I believe these points are not contributing in breaking API :D so lets talk on them first. 2. You mean instead of an array I'm using here [1], We should add them as constants and write separate documentation for each? This sounds nice as it will help obviously like you said. 3. Ohh, I missed this convention, thanks for pointing this out. :) 4. As you said its more of a judgement call, I believe that RGB strings are fine and easy for users. You find any wrong in RGB strings? So, I'll be very happy to co-operate if you are doing pull request covering points 2 and 3 :) And I'll try to cover your point 1 on my own :) Cheers \o/ [1] https://github.com/pravj/geo_pattern/blob/master/pattern/pat...

import "github.com/pravj/geo_pattern/pattern" will import from the file system, at $GOPATH/src/github.com/pravj/geo_pattern/pattern/ however, go get will fetch from the URL and install it in said path (it's a mixed blessing) The [free] Little Go Book [1] makes a special note of it :) [1] http://openmymind.net/assets/go/go.pdf