BYbyroot·Jan 3, 2025
> Using the benchmarks in the Oj test directory
I'm sorry, but I've looked for a while now, and I can't seem to identify the benchmark you are mentioning. I suspect it's the one John took for his benchmark suite? [0]
> Oj has a slight advantage over the core json for dumping but not enough to make much difference
I'd be curious to see which benchmark you are using, because on the various ones included in ruby/json, Oj is slightly slower on about all of them: https://gist.github.com/byroot/b13d78e37b5c0ac88031dff763b3b..., except for scanning strings with lots of multi-byte characters, but I have a branch I need to finish that should fix that.
> The comparison for Oj strict parsing compared to the core json is more substantial as 1.37 times faster
Here too I'd be curious to see your benchmark suite because that doesn't match mine: https://
Read the rest
gist.github.com/byroot/dd4d4391d45307a47446addeb7774...
> The callback parsers (Saj and Scp) also show a performance advantage as does the most recent Oj::Parser.
Yeah, callback parsing isn't something I plan to support, at least not for now. As for Oj::Parser, `ruby/json` got quite close to it, but then @tenderlove pointed to me that the API I was trying to match wasn't thread safe, hence it wasn't a fair comparison, so now I still bench against it, but with a new instance every time: https://github.com/ruby/json/pull/703.
> You picked the wrong options for you example.
No, I picked them deliberately. That's the sort of behavior users don't expect and can be bitten by.
As a matter of fact, I discovered this behavior because one of the benchmark payloads (canada.json) doesn't roundtrip cleanly with Oj's default mode, that's why I benchmark against the `:compat` mode. IMO truncating data for speed isn't an acceptable default config.
[0] https://github.com/jhawthorn/rapidjson-ruby/blob/518818e6768...