active_merchant

I see what you mean, and it almost seems like the "sin" isn't the additional editing, it's the subsequent rebase. It's one thing to require contributors to rebase, but it seems like another to rebase for them. Maybe I'm missing something, but based on the "History Is Written By the Victors" section of TFA I would have been surprised to see anyone other than @ntalbott at the top of https://github.com/Shopify/active_merchant/graphs/contributo...

Wow, this really made my evening :) I just donated two hours worth of my consulting time for two fellow human beings in need somewhere else in the world and it will have serious impact. I'm in total bliss <3 nothing feels like helping others - you should try donating! The only thing I would like to see watsi doing is to offer donations with bitcoin! Integration with bitpay is really easy too. If watsi is rails based (seems so) they would have support for bitpay out of the box with active merchant! Go spread some love folks, it feels great! http://watsi.org Edit: https://bitpay.com (they offer immediate conversion to local currencies too!) https://github.com/Shopify/active_merchant/tree/13e0ab52727b...

"JavaScript libraries like jQuery aren't well equiped to handle form input, so Creditcard.js uses the more robust and comprehensive Google Closure Tools, the heavily tested JavaScript framework behind Gmail and Google Plus." really? you're gonna do jQuery (+ all validation plugins) bashing for what? 5 fields + a luhn algo? please, take your snake oil elsewhere. "the heavily tested JavaScript framework"? you must not follow jQuery's own pedantic development and testing, i would argue it is more heavily tested than Google's we-only-support-latest-2-versions-of-any-browser libs. if anyone needs to do client-side cc pre-checks, there's a pretty up-to-date regex list [1] and a luhn implementation [2] which will get you 99.9% there. if you feel that the 0.1% (but probably much less) is worth a monthly licensing fee, you now have options :) [1]

I did the same thing a while back; you might want to look into the actual braintree gem itself, it's pretty solid. AM is now (for BrainTree, anyway) a pretty simple wrapper on top of it: https://github.com/Shopify/active_merchant/blob/master/lib/a...