sweetalert

Looks good! Noticed a few weird things though: - `overflow: hidden` on body makes the page content jump as the scrollbar (dis)appears. There's an issue for that [0] - `sweet-overlay` div has a different opacity on each open for some reason? I've seen 1.01 through 1.05, so they are all effectively 1, but it just seems weird to me… It probably has something to do with the `fadeIn` function [1]. Was there any reason not to use CSS transitions for fading? There's a fork called sweetalert2 [2] with more active development [3]. It has these two things (and probably many others) fixed. -- [0] https://github.com/t4t5/sweetalert/issues/590 [1] https://github.com/t4t5/sweetalert/blob/master/dev/modules/h... [2] https://limonte.github.io/sweetalert2/ [3] https://github.com/limonte/sweetalert2/graphs/contributors

This is an eerily similar project to something posted a few weeks ago here. Most notably, the exact same "success" animation. https://news.ycombinator.com/item?id=8420902 https://github.com/t4t5/sweetalert

Though the alert may look nice, the actual JS behind it is hugely wanting for several reasons: - 690 LOC to produce an alert dialog - Heavy use of Javascript for what CSS is designed for: https://github.com/t4t5/sweetalert/blob/master/lib/sweet-ale... - Inconsistent between function spacing followed by mixed tabs and spaces - Odd use of DOM based attributes to pass configuration options - Colourspace manipulation on each call where SASS would be effective https://github.com/t4t5/sweetalert/blob/master/lib/sweet-ale... - Includes jquery, but uses it very little, instead opting to re-invent the wheel in most cases. - Strange click event firing, gratuitous use of magic key code numbers https://github.com/t4t5/sweetalert/blob/master/lib/sweet-ale... etc...

Apologies, it appears that keyboard handlers have been added since I last tested this a few days ago. https://github.com/t4t5/sweetalert/commit/2413e5cbcd1fe3d6e1...

One of the examples shows that they have a single callback function: http://tristanedwards.me/sweetalert Unfortunately, there's only one function so this isn't useful if you want to run code when the user cancels the dialog: https://github.com/t4t5/sweetalert/blob/750a0fd72c3beaa6d4d7...