tonal

I appreciate the feedback and sanity checking! I’m definitely planning on add a wider array of chords types now that the app is basically working. As far as the 7th inversions, I essentially “ignored” inversions by flattening the notes into a single octave … there may be an issue with this logic. I came across <https://chord-display.rednet.io> myself yesterday and took a cursory look. Nice app. They use a library called `tonal` <https://github.com/tonaljs/tonal> for their music theory logic, which ought to be a good resource to validate against.

https://github.com/tonaljs/tonal does a bunch of theory stuff. I think there’s another JS library I’ve used too but I can’t think of the name. If he wants to generate audio, Tone.js can be a useful higher level abstraction for WebAudio.

I don't mean to lose my 'temper' here, but I think gp is hoping Note.freq(), Note.fromFreq(), etc. aren't locked into A440 as the examples imply. While >99% of the library doesn't deal with this at all, it would be handy nonetheless. Unfortunately, it's currently hard coded: https://github.com/tonaljs/tonal/blob/main/packages%2Fpitch-... https://github.com/tonaljs/tonal/blob/main/packages%2Fmidi%2...

They're using objects, including arrays [1], so I think they would have been more precise to say that they're using objects and arrays as simple data structures rather than using OO features like inheritance and mutation. [1] https://github.com/tonaljs/tonal/blob/main/packages/chord/in...

Regarding the "Music Theory library" aspect, note that the CLI tool demonstrates use of the underlying Ruby library which has documentation here: * https://github.com/pedrozath/coltrane/wiki/Core-music-theory... Additionally, the author wrote a post about the motivation for creating the library but it's a little difficult to find via the (now broken) link in the README, so here is a direct link to the archived page on the Wayback Machine: * https://web.archive.org/web/20170714063625/https://medium.co... If anyone is interested in a similar music theory library for Javascript[0] I've had some success with this: * Tonal / Tonal.js https://github.com/tonaljs/tonal [0] Or, in a pinch, even with a Godot 4 web export as I did for my (very incomplete) "AI and Games" Game Jam entry: https://rancidbacon.itch.io/the-conductor (For reasons far too c

Thanks for trying it! There's no support for Maj7(no3) chords at the moment. It's a less common pattern, but would be easy to add support! At the moment, I'm using tonal for chord recognition under the hood, so these are the chord types that it can recognize: https://github.com/danigb/tonal/blob/master/packages/diction...